[SES-1931] - Fix debouncer crash #1492
Conversation
| @@ -5,9 +5,9 @@ import android.content.Context | |||
| import org.session.libsession.utilities.Debouncer | |||
| import org.thoughtcrime.securesms.ApplicationContext | |||
|
|
|||
| class ConversationNotificationDebouncer(private val context: Context) { | |||
| class ConversationNotificationDebouncer(private val context: ApplicationContext) { | |||
I'd love to use Kotlin Flow in the hopefully not very far future |
| debouncer.publish { publish() } | ||
| } | ||
|
|
||
| private fun publish() { | ||
| for (threadID in threadIDs.toList()) { | ||
| val toNotify = synchronized(threadIDs) { |
There was a problem hiding this comment.
I was just thinking, you can save the list copy by making it a var:
private fun publish() {
synchronized(this) {
threadIDs.also { threadIDs = mutableSetOf() }
}.forEach {
context.contentResolver.notifyChange(DatabaseContentProviders.Conversation.getUriForThread(it), null)
}
but it needs the same synchronized(this) in notify.
Creating a new instance still needs an allocation, but toList needs an allocation and an O(n) copy. Probably negligible performance, so don't feel obliged to change it, but the syntax is nice-ish too.
There was a problem hiding this comment.
I actually went down this path to avoid the copying and using AtomicReference to avoid synchronization but had since decided against it, as I think easier to read code is more important than a few nanoseconds off the hotspot.
There was a problem hiding this comment.
Also considered using a sorted long[] to avoid boxing but feel really unnecessary here, most of the time you only see a few items in the list really...
Description
The
ConversationNotificationDebouncerdoesn't handle threaded code correctly, added sync block manually.This PR also makes sure no activity context is ever stored inside this singleton object.